[libvirt] [PATCH RFC 26/51] qemu: blockjob: Remove error propagation from qemuBlockJobUpdateDisk

Ján Tomko jtomko at redhat.com
Mon Jan 7 14:55:24 UTC 2019


On Wed, Dec 12, 2018 at 06:08:42PM +0100, Peter Krempa wrote:
>The job error can be safely accessed in the job structure, so we don't
>need to propagate it through qemuBlockJobUpdateDisk.
>
>Drop the propagation and refactor any caller that pased non-NULL error.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_blockjob.c  | 12 ++----------
> src/qemu/qemu_blockjob.h  |  3 +--
> src/qemu/qemu_driver.c    |  6 +++---
> src/qemu/qemu_migration.c | 28 +++++++++++-----------------
> 4 files changed, 17 insertions(+), 32 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190107/969ff6d5/attachment-0001.sig>


More information about the libvir-list mailing list