[libvirt] [PATCH RFC 28/51] qemu: blockjob: Pass job into qemuBlockJobUpdateDisk and rename it

[Ján Tomko]

On Wed, Dec 12, 2018 at 06:08:44PM +0100, Peter Krempa wrote:
>Instead of passing in the disk information, pass in the job and name the
>function accordingly.
>
>Few callers needed to be modified to have the job pointer handy.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_blockjob.c  | 20 ++++++++++++--------
> src/qemu/qemu_blockjob.h  |  6 +++---
> src/qemu/qemu_driver.c    |  6 +++---
> src/qemu/qemu_migration.c | 40 +++++++++++++++++++++++++++------------
> 4 files changed, 46 insertions(+), 26 deletions(-)
>
>diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
>index 49e747ebbb..c1826baa3c 100644
>--- a/src/qemu/qemu_blockjob.c
>+++ b/src/qemu/qemu_blockjob.c
>@@ -333,7 +333,7 @@ qemuBlockJobEventProcessLegacy(virQEMUDriverPtr driver,
>
>
> /**
>- * qemuBlockJobUpdateDisk:
>+ * qemuBlockJobUpdate:
>  * @vm: domain
>  * @disk: domain disk

Again, the documentation is out of date.

>  * @error: error (output parameter)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190107/88eb68fb/attachment-0001.sig>