[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH RFC 28/51] qemu: blockjob: Pass job into qemuBlockJobUpdateDisk and rename it



On Wed, Dec 12, 2018 at 06:08:44PM +0100, Peter Krempa wrote:
Instead of passing in the disk information, pass in the job and name the
function accordingly.

Few callers needed to be modified to have the job pointer handy.

Signed-off-by: Peter Krempa <pkrempa redhat com>
---
src/qemu/qemu_blockjob.c  | 20 ++++++++++++--------
src/qemu/qemu_blockjob.h  |  6 +++---
src/qemu/qemu_driver.c    |  6 +++---
src/qemu/qemu_migration.c | 40 +++++++++++++++++++++++++++------------
4 files changed, 46 insertions(+), 26 deletions(-)

diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c
index 49e747ebbb..c1826baa3c 100644
--- a/src/qemu/qemu_blockjob.c
+++ b/src/qemu/qemu_blockjob.c
@@ -333,7 +333,7 @@ qemuBlockJobEventProcessLegacy(virQEMUDriverPtr driver,


/**
- * qemuBlockJobUpdateDisk:
+ * qemuBlockJobUpdate:
 * @vm: domain
 * @disk: domain disk

Again, the documentation is out of date.

 * @error: error (output parameter)

Reviewed-by: Ján Tomko <jtomko redhat com>

Jano

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]