[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH RFC 29/51] qemu: Allocate diskPriv->blockjob only when there's a blockjob



On Wed, Dec 12, 2018 at 06:08:45PM +0100, Peter Krempa wrote:
Rather than storing the presence of the blockjob in a flag we can bind
together the lifecycle of the job with the lifecycle of the object which
is tracking the data for it.

Signed-off-by: Peter Krempa <pkrempa redhat com>
---
src/qemu/qemu_blockjob.c | 76 +++++++++++++++++++++++++++++-----------
src/qemu/qemu_blockjob.h |  1 -
src/qemu/qemu_domain.c   |  5 ---
3 files changed, 55 insertions(+), 27 deletions(-)

@@ -333,7 +355,7 @@ qemuBlockJobEventProcessLegacy(virQEMUDriverPtr driver,


/**
- * qemuBlockJobUpdate:
+ * qemuBlockJobUpdateDisk:

Unrelated change.

 * @vm: domain
 * @disk: domain disk
 * @error: error (output parameter)

Reviewed-by: Ján Tomko <jtomko redhat com>

Jano

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]