[libvirt] [PATCH 2/3] maint: Prefer AM_CPPFLAGS over INCLUDES

Eric Blake eblake at redhat.com
Mon Jan 7 22:45:36 UTC 2019


On 1/7/19 5:19 AM, Ján Tomko wrote:
> On Fri, Jan 04, 2019 at 02:12:19PM -0600, Eric Blake wrote:
>> Our use of INCLUDES in Makefile.am hearkens back to when we had to
>> cater to automake 1.9.6 (thanks, RHEL 5) which lacked AM_CPPFLAGS.
>> Modern Automake flags a warning that INCLUDES is deprecated, and
>> now that we mandate RHEL 7 or better (see commit c1bc9c66), we no
>> longer have to cater to the old spelling.
>>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
>> ---
>> examples/Makefile.am | 3 ++-
>> src/Makefile.am      | 2 +-
>> tests/Makefile.am    | 4 ++--
>> tools/Makefile.am    | 2 +-
>> 4 files changed, 6 insertions(+), 5 deletions(-)
>>
> 
> Reviewed-by: Ján Tomko <jtomko at redhat.com>

I've pushed the first two while revisiting the third for a v2.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190107/15ff668b/attachment-0001.sig>


More information about the libvir-list mailing list