[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/3] Fix examples/ under mingw



My recent patch to make all of the examples work independently of
gnulib worked fine on Linux, but failed on mingw:
https://travis-ci.org/libvirt/libvirt/jobs/476898635

The whole point of gnulib is to work around portability pitfalls so
we don't have to bend over backwards thinking about it in our code;
and it would be possible to fix this bug by linking the problematic
example binaries against gnulib after all.  But since the examples
are still small and self-contained enough that using manual
workarounds wasn't too daunting, that's the approach I took here.

I'm pushing this series as a build-breaker fix in a couple of hours,
or sooner if I get a review.

Eric Blake (3):
  examples: Work around mingw printf() weakness
  examples: Work around lack of mingw sigaction()
  examples: Work around lack of mingw localtime_r()

 cfg.mk                              |  2 +-
 examples/admin/client_info.c        |  6 +++++-
 examples/admin/list_clients.c       |  6 +++++-
 examples/domtop/domtop.c            | 13 ++++++-------
 examples/object-events/event-test.c | 16 +++++++---------
 5 files changed, 24 insertions(+), 19 deletions(-)

-- 
2.20.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]