[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] examples: include config.h



On Wed, Jan 09, 2019 at 10:24:40AM +0000, Daniel P. Berrangé wrote:
On Fri, Jan 04, 2019 at 04:22:42PM +0100, Ján Tomko wrote:
Since gnulib commit 6954995d unistd.h is included via stdlib.h
on BSD systems, which requires config.h to be included first.

Add config.h to the files that use it.

This is not desirable.  The examples/ programs are supposed to
be self-contained demos that you can compile outside of libvirt.
They should not require any of the autoconf related stuff lilke
config.h


Yes, this has been already reverted by Eric in:
commit acf522e85a9747457e6d81a6cae9eef1cf677ff0

Author:     Eric Blake <eblake redhat com>
CommitDate: 2019-01-08 09:26:51 -0600

   examples: Avoid gnulib, have standalone examples

Jano

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]