[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 3/6] docs, tests: Add schema, description, and tests for NFS namespace



On 1/8/19 6:52 PM, John Ferlan wrote:
> Modify the storagepool.rng to allow for the usage of a different
> XML namespace to parse the netfs_mount_opts to be included with
> the storage source.
> 
> Modify the storagepoolxml2xmltest to utilize a properly modified
> XML file to parse and format the namespace for a netfs storage pool.
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  docs/formatstorage.html.in                    | 42 +++++++++++++++++++
>  docs/schemas/storagepool.rng                  | 20 +++++++++
>  tests/Makefile.am                             |  4 +-
>  .../pool-netfs-mountopts.xml                  | 24 +++++++++++
>  .../pool-netfs-mountopts.xml                  | 24 +++++++++++
>  tests/storagepoolxml2xmltest.c                |  6 +++
>  6 files changed, 119 insertions(+), 1 deletion(-)
>  create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-mountopts.xml
>  create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-mountopts.xml
> 


> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index f74d8463b6..373d347389 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -937,7 +937,9 @@ storagevolxml2xmltest_LDADD = $(LDADDS)
>  storagepoolxml2xmltest_SOURCES = \
>  	storagepoolxml2xmltest.c \
>  	testutils.c testutils.h
> -storagepoolxml2xmltest_LDADD = $(LDADDS)
> +storagepoolxml2xmltest_LDADD = $(LDADDS) \
> +	../src/libvirt_driver_storage_impl.la \
> +	../gnulib/lib/libgnu.la

Or $(GNULIB_LIBS)

>  
>  nodedevxml2xmltest_SOURCES = \
>  	nodedevxml2xmltest.c \

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]