[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 0/4] util: Fixing libvirt errors on cavium/thunder-nicvf



On Wed, Dec 12, 2018 at 12:23 PM dann frazier
<dann frazier canonical com> wrote:
>
> On Sat, Nov 17, 2018 at 1:17 PM Radoslaw Biernacki
> <radoslaw biernacki linaro org> wrote:
> >
> > ThunderX is Cavium SoC. This platform contain SRIOV NIC.
> > Unlike other commonly known network devices it does not have VF functionality
> > duplicated in its PF. PF is purely management device (on HW level).
> >
> > This creates several problems with existing libvirt code as in many places
> > libvirt assumes that each VF netdev has PF netdev assigned.
> >
> > This patch series trying to address issues which can be easily fixed.
> > (mostly bug fixes found while working on full featured solution)
> >
> > First patch in series is most important as it allows to unblock the netdev
> > detection and use <hostdev> on this platform.i <interface type="hostdev"
> > still does not work as it requires bigger changes both on netdev driver
> > and in libvirt itself.
> > More details about those issues can be found at:
> > https://bugs.linaro.org/show_bug.cgi?id=3778
> > https://bugs.launchpad.net/charm-nova-compute/+bug/1771662
> >
> > v2:
> > - error reporting taken out of virNetDevGetPhysicalFunction() and moved
> >   to calling function virNetDevGetVirtualFunctionInfo()
> > - curly braces removed from single line
> > - net-> model check removed as STREQ_NULLABLE() follows
>
> Thanks Radoslaw ! I know a v3 is in the works, but just an fyi that we
> ran this series through our OpenStack testing on a cluster of ThunderX
> nodes and found no issues.

hey Radoslaw,

  Thanks for all of your work on this so far on this. Do you expect to
have time to prepare a v3, or would it help if I took a crack at it?

  -dann


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]