[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 2/3] src: Only install SysV init scripts when libvirtd is built



On Thu, 2019-01-10 at 16:32 +0100, Erik Skultety wrote:
> On Thu, Jan 10, 2019 at 03:11:45PM +0100, Andrea Bolognani wrote:
> > This is consistent with the way we already handle
> > configuration for other init systems such as upstart and
> > systemd.
> 
> Apart from consistency, I wonder whether we still need that extra condition or
> it's a historical artefact we can get rid of.

Without those conditions, one could conceivably run

  ./configure --with-libvirtd=no --with-init-script=systemd

and end up with a bunch of .service files, pointing to binaries
that don't exist, installed on the system.

Whether or not we should even prepare for such a scenario is
of course up for debate, but the conditions are not, strictly
speaking, useless.

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]