[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] qemu: Remove virHostdevIsSCSIDevice from qemuIsSharedHostdev

On Thu, Jan 10, 2019 at 06:40:33PM -0500, John Ferlan wrote:
It's essentially dead code. The only way hostdev->shareable
can be true is during virDomainHostdevDefParseXML when the
result of virHostdevIsSCSIDevice is true.

While this might be true in our current codebase,
I don't think this function should rely on the callers
to only fill in hostdev->shareable for VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_SCSI
to guard its usage of the hostdev->source union.


Signed-off-by: John Ferlan <jferlan redhat com>
src/qemu/qemu_conf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index 20952e9607..945725566c 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -1438,8 +1438,7 @@ static bool
qemuIsSharedHostdev(virDomainHostdevDefPtr hostdev)
    return (hostdev->shareable &&
-            (virHostdevIsSCSIDevice(hostdev) &&
-             hostdev->source.subsys.u.scsi.protocol !=
+            (hostdev->source.subsys.u.scsi.protocol !=


libvir-list mailing list
libvir-list redhat com

Attachment: signature.asc
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]