[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] src: Don't use double-colon rules



On Fri, Jan 11, 2019 at 11:23:33AM +0100, Andrea Bolognani wrote:
> According to the GNU Make manual, "double-colon rules are
> somewhat obscure and not often very useful". Looking at
> the few instances we have in libvirt, that certainly seems
> to be the case, so just drop them.

I actually wanted to ask about that during the review process of your previous
series, but I forgot, so thanks for addressing that too. I found a practical
example [1] where it *can* be useful, but we don't collect the actions
gradually (or as they call it "vertically").

Reviewed-by: Erik Skultety <eskultet redhat com>

[1] https://web.archive.org/web/20180122002430/http://owen.sj.ca.us/~rk/howto/slides/make/slides/makecolon.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]