[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: make forgotten changes suggested during review of commit d40b820c

On Sun, Jan 13, 2019 at 12:42:20AM -0500, Laine Stump wrote:
I had intended to make these changes to commit d40b820c before
pushing, but forgot about it during the day between the initial review
and ACK.

Neither change is significant - just returning immediately when
virNetDevGetName() faills (instead of logging a debug message first)


and eliminating a comment that adds to confusion rather than
eliminating it. Still, the changes should be made to be more consistent with nearly identical code just a few lines up (added in commit 7282f455)

Please wrap this long line.

Signed-off-by: Laine Stump <laine laine org>
src/util/virnetdevip.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

Reviewed-by: Ján Tomko <jtomko redhat com>


Attachment: signature.asc
Description: PGP signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]