On Mon, Jan 14, 2019 at 17:05:50 +0000, Daniel Berrange wrote: > On Mon, Jan 14, 2019 at 06:01:24PM +0100, Peter Krempa wrote: > > On Mon, Jan 14, 2019 at 17:57:39 +0100, Michal Privoznik wrote: > > > Turns out, that there are few bugs that are not that trivial to > > > fix (e.g. around block jobs). Instead of rushing in not > > > thoroughly tested fixes disable the feature temporarily for the > > > release. > > > > > > Signed-off-by: Michal Privoznik <mprivozn redhat com> [...] > > > diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c > > > index 20952e9607..b03e38b831 100644 > > > --- a/src/qemu/qemu_conf.c > > > +++ b/src/qemu/qemu_conf.c > > > @@ -145,7 +145,6 @@ virQEMUDriverConfigPtr virQEMUDriverConfigNew(bool privileged) > > > cfg->group = (gid_t)-1; > > > } > > > cfg->dynamicOwnership = privileged; > > > - cfg->rememberOwner = privileged; > > > > Can't we just set this to false and add a note to the qemu.conf file > > that it's currently disabled as being unstable so that you don't have to > > delete the qemu_conf.c changes? > > If we do that, then people can turn it on. Then we have to ensure we can > handle upgrades correctly. If it is buggy, it is safer to never let users > turn it on so we don't get ourselves into a painful place with upgrades > from the buggy version I would not feel bad for anybody enabling a option which is clearly marked as broken which would make their stuff blow up. Anyways. ACK even to the original patch since I don't care that much.
Description: PGP signature