[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: audit: Fix the error code when kernel lacks audit support



On Tue, Jan 15, 2019 at 04:08 PM +0100, Erik Skultety <eskultet redhat com> wrote:
> When commit 4199c2f221c tweaked the error path of virAuditOpen it used
> VIR_FROM_THIS as the error code to virReportError.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1596119
>
> Signed-off-by: Erik Skultety <eskultet redhat com>
> ---
>  src/util/viraudit.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/util/viraudit.c b/src/util/viraudit.c
> index a02e5b36fd..d04343a542 100644
> --- a/src/util/viraudit.c
> +++ b/src/util/viraudit.c
> @@ -66,7 +66,8 @@ int virAuditOpen(unsigned int audit_level ATTRIBUTE_UNUSED)
>              if (audit_level < 2)
>                  VIR_INFO("Audit is not supported by the kernel");
>              else
> -                virReportError(VIR_FROM_THIS, "%s", _("Audit is not supported by the kernel"));
> +                virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> +                               _("Audit is not supported by the kernel"));
>          } else {
>              virReportSystemError(errno, "%s", _("Unable to initialize audit layer"));
>          }
> --
> 2.20.1
>
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list
>

Thanks for fixing!

Reviewed-by: Marc Hartmayer <mhartmay linux ibm com>

--
Kind regards / Beste Grüße
   Marc Hartmayer

IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Matthias Hartmann
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]