[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/5] docs: add forgotten mentions of forward mode "open"



On Wed, Jan 09, 2019 at 09:57:33PM -0500, Laine Stump wrote:
> A couple places in the docs didn't get updated when the forward mode
> "open" was added.
> 
> Signed-off-by: Laine Stump <laine laine org>
> ---
>  docs/formatnetwork.html.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/docs/formatnetwork.html.in b/docs/formatnetwork.html.in
> index 363a72bbc9..156cfae4ec 100644
> --- a/docs/formatnetwork.html.in
> +++ b/docs/formatnetwork.html.in
> @@ -107,13 +107,13 @@
>          may also be connected to the LAN. When defining
>          a new network with a <code>&lt;forward&gt;</code> mode of
>  
> -        "nat" or "route" (or an isolated network with
> +        "nat", "route", or "open" (or an isolated network with
>          no <code>&lt;forward&gt;</code> element), libvirt will
>          automatically generate a unique name for the bridge device if
>          none is given, and this name will be permanently stored in the
>          network configuration so that that the same name will be used
>          every time the network is started. For these types of networks
> -        (nat, routed, and isolated), a bridge name beginning with the
> +        (nat, route, open, and isolated), a bridge name beginning with the
>          prefix "virbr" is recommended (and that is what is
>          auto-generated), but not enforced.
>          Attribute <code>stp</code> specifies if Spanning Tree Protocol

Reviewed-by: Daniel P. Berrangé <berrange redhat com>

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]