[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/5] util: new function virFirewallDInterfaceSetZone()

or more simply "util: Introduce virFirewallDInterfaceSetZone"

On 1/9/19 9:57 PM, Laine Stump wrote:
> Sets the firewalld zone of the given interface. This function assumes
> that you've already called virFirewallDIsActive(), and relies on
> virDBusCallMethod's standard error reporting to log any errors.
> Signed-off-by: Laine Stump <laine laine org>
> ---
>  src/libvirt_private.syms |  1 +
>  src/util/virfirewalld.c  | 23 +++++++++++++++++++++++
>  src/util/virfirewalld.h  |  3 +++
>  3 files changed, 27 insertions(+)

Caveat - not my area of knowledge, but from a learning PoV for me...

Any concerns over with this is a "compute intensive" type operation for
firewalld and whether it's felt it would be useful to getZoneOfInterface
first and compare vs. the passed zone before calling the
changeZoneOfInterface? My thoughts here are along the lines of other
(somewhat) recent upstream patches related to performance issues that
I've seen from Nikolay and Dan.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]