[libvirt] [PATCH] docs: remove duplicate example usegae of nvdimm

Luyao Zhong luyao.zhong at intel.com
Wed Jan 16 08:58:52 UTC 2019



On 2019/1/16 下午4:16, Peter Krempa wrote:
> On Wed, Jan 16, 2019 at 14:58:21 +0800, Luyao Zhong wrote:
>> original:
>> <devices>
>>    <memory model='nvdimm'>
>>    ...
>>    </memory>
>>    <memory model='nvdimm'>
>>    ...
>>    </memory>
>> </devices>
>>
>> merge two examples above into one:
>> <devices>
>>    <memory model='nvdimm'>
>>    ...
>>    </memory>
>> </devices>
>>
>> Signed-off-by: Luyao Zhong <luyao.zhong at intel.com>
> 
> What's the benefit of the above change? We have multiple instances where
> we show different configurations so I don't see a need to squash
> every option together.
> 
Thank you for your reply.

I modify this because the two different instances may mislead people to 
think these are two mutually exclusive way to configure NVDIMM. Besides, 
one example is enough to show all configurations and the description 
bellow give the details.

Actually I thought it is a bug, because there was only one instance. I 
added several options for the NVDIMM before but don't know why the one 
instance was divided into two. :)

Thanks,
Luyao




More information about the libvir-list mailing list