[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/6] RFC: qemu: virtio-{non-}transitional support

On Tue, 2019-01-15 at 17:06 +0000, Daniel P. Berrangé wrote:
> virDomainNetDef is a mess because it *still* doesn't use a enum
> for the device model :-(   We really must fix that rather than
> blindly allowing arbitrary passthrough of hypervisor specific
> names.
> I recall Laine had patches for this some 4/5 years ago, but
> can't remember why we never merged them.

Based on what I can recall from my own, more recent, attempt at
fixing the mess, the main blocker was that in order to keep
accepting all existing configurations you'd basically have to
still store the model as a string and only at a later time
convert it to an enum.

So you'd end up making the code more complicated rather than
simpler which, needless to say, makes the idea way less
attractive :(

Andrea Bolognani / Red Hat / Virtualization

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]