[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 03/23] qemu.conf: fill out TLS verify attributes after parsing




On 1/15/19 8:22 AM, Ján Tomko wrote:
> Introduce a set of bool variables with the 'present' suffix
> to track whether the value was actually specified.
> 
> Signed-off-by: Ján Tomko <jtomko redhat com>
> ---
>  src/qemu/qemu_conf.c   | 28 ++++++++++++++++++++++++----
>  src/qemu/qemu_conf.h   |  6 ++++++
>  src/qemu/qemu_driver.c |  3 +++
>  3 files changed, 33 insertions(+), 4 deletions(-)
> 

6 of one, half-dozen of another.

There should be two empty lines before/after the new method below even
though it's not the norm in the file.

And yes, the ret = 0; return ret; looks odd now, but I see usage in next
patch...

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]