[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 04/23] qemu: fill out usage-specific TLS settings after parsing

On 1/15/19 8:23 AM, Ján Tomko wrote:
> Instead of copying the default default values upfront
> and then wondering whether the user has given us a new default,
> leave the per-usage TLS certdirs and secrets empty during
> parsing and only fill them afterwards if they weren't provided
> by the user.
> This means that instead of looking whether the specific certdir
> paths match the default default, the Validate function (which
> is called inbetween parsing and setting the defaults) can error

in between

> out for missing directories if the value is present, because
> it must've come from the user.
> Signed-off-by: Ján Tomko <jtomko redhat com>
> ---
>  src/qemu/qemu_conf.c | 150 ++++++++++++++++---------------------------
>  1 file changed, 56 insertions(+), 94 deletions(-)

Reviewed-by: John Ferlan <jferlan redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]