[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 12/23] qemu_conf: split out virQEMUDriverConfigLoadRPCEntry




On 1/15/19 8:23 AM, Ján Tomko wrote:
> Split out parts of the config parsing code to make
> the parent function easier to read.
> 
> Signed-off-by: Ján Tomko <jtomko redhat com>
> ---
>  src/qemu/qemu_conf.c | 21 +++++++++++++++------
>  1 file changed, 15 insertions(+), 6 deletions(-)
> 
> diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
> index 8aa5157cd1..b555e33e7b 100644
> --- a/src/qemu/qemu_conf.c
> +++ b/src/qemu/qemu_conf.c
> @@ -423,6 +423,20 @@ virQEMUDriverConfigHugeTLBFSInit(virHugeTLBFSPtr hugetlbfs,
>  }
>  
>  
> +static int
> +virQEMUDriverConfigLoadRPCEntry(virQEMUDriverConfigPtr cfg,
> +                                virConfPtr conf)
> +{
> +    if (virConfGetValueUInt(conf, "max_queued", &cfg->maxQueuedJobs) < 0)
> +        return -1;
> +    if (virConfGetValueInt(conf, "keepalive_interval", &cfg->keepAliveInterval) < 0)
> +        return -1;
> +    if (virConfGetValueUInt(conf, "keepalive_count", &cfg->keepAliveCount) < 0)
> +        return -1;
> +
> +    return 0;
> +}
> +

blank line

Reviewed-by: John Ferlan <jferlan redhat com>

John

[...]


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]