[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 6/8] qemu.conf: add vnc_tls_x509_secret_uuid




On 1/16/19 2:41 AM, Ján Tomko wrote:
> Add an option that lets the user specify the secret
> that unlocks the server TLS key.
> 
> Signed-off-by: Ján Tomko <jtomko redhat com>
> ---
>  src/qemu/libvirtd_qemu.aug         | 1 +
>  src/qemu/qemu.conf                 | 6 ++++++
>  src/qemu/qemu_conf.c               | 3 +++
>  src/qemu/qemu_conf.h               | 1 +
>  src/qemu/test_libvirtd_qemu.aug.in | 1 +
>  5 files changed, 12 insertions(+)
> 


Missing a change to virQEMUDriverConfigDispose in order to
VIR_FREE(cfg->vncTLSx509secretUUID);

with that,

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]