[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH v4 00/10] Allow adding mountOpts to the storage pool mount command



v3: https://www.redhat.com/archives/libvir-list/2019-January/msg00467.html

NB: Kept same subject for cover to keep the same context; however, it's
now more of a series of a few things...  Add default NFS Server options,
add nfsvers, and add support for XML namespaces in storage pools which
are used by NFS and RBD storage pools.

Changes since v3:

Remove patch 1 and 3.  Rework patch 2 to make the nodev, nosuid, and
noexec be the "default options" for the NFS Storage Pool. Created a
virStorageBackendFileSystemMountNFSAddOptions in order to add those
options for NFS pools using format NFS (and not 'cifs' or 'gluster').

Everything else just gets adjusted/merged based on how the first patch
works.


John Ferlan (10):
  storage: Add default mount options for NFS Storage Pools
  docs: Add news mention of NFS Storage Pool mount options
  conf: Add optional NFS Source Pool <protocol ver='n'/> option
  storage: Add the nfsvers to the command line
  virsh: Add source-protocol-ver for pool commands
  conf: Introduce virStoragePoolXMLNamespace
  nfs: Add infrastructure to manage XML namespace options
  docs,tests: Add schema, description, and tests for NFS namespace
  storage: Add NFS storage pool namespace options to command line
  rbd: Utilize storage pool namespace to manage config options

 docs/formatstorage.html.in                    | 123 +++++++++++++
 docs/news.xml                                 |  11 ++
 docs/schemas/storagepool.rng                  |  50 ++++++
 src/conf/storage_conf.c                       |  73 +++++++-
 src/conf/storage_conf.h                       |  27 +++
 src/libvirt_private.syms                      |   1 +
 src/storage/storage_backend_fs.c              | 128 ++++++++++++++
 src/storage/storage_backend_rbd.c             | 166 +++++++++++++++++-
 src/storage/storage_util.c                    |  52 ++++++
 src/storage/storage_util.h                    |  14 ++
 tests/Makefile.am                             |   4 +-
 .../pool-netfs-auto-freebsd.argv              |   1 +
 .../pool-netfs-auto-linux.argv                |   1 +
 .../pool-netfs-freebsd.argv                   |   1 +
 .../pool-netfs-linux.argv                     |   1 +
 .../pool-netfs-ns-mountopts-freebsd.argv      |   2 +
 .../pool-netfs-ns-mountopts-linux.argv        |   2 +
 .../pool-netfs-ns-mountopts.argv              |   1 +
 .../pool-netfs-protocol-ver-freebsd.argv      |   1 +
 .../pool-netfs-protocol-ver-linux.argv        |   2 +
 .../pool-netfs-protocol-ver.argv              |   1 +
 tests/storagepoolxml2argvtest.c               |  49 +++++-
 .../pool-netfs-ns-mountopts.xml               |  25 +++
 .../pool-netfs-protocol-ver.xml               |  21 +++
 .../pool-rbd-ns-configopts.xml                |  17 ++
 .../pool-netfs-ns-mountopts.xml               |  25 +++
 .../pool-netfs-protocol-ver.xml               |  21 +++
 .../pool-rbd-ns-configopts.xml                |  20 +++
 tests/storagepoolxml2xmltest.c                |   8 +
 tools/virsh-pool.c                            |  12 +-
 tools/virsh.pod                               |   5 +
 31 files changed, 851 insertions(+), 14 deletions(-)
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-auto-freebsd.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-auto-linux.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-freebsd.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-linux.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-ns-mountopts-freebsd.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-ns-mountopts-linux.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-ns-mountopts.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-protocol-ver-freebsd.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-protocol-ver-linux.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-protocol-ver.argv
 create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-ns-mountopts.xml
 create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-protocol-ver.xml
 create mode 100644 tests/storagepoolxml2xmlin/pool-rbd-ns-configopts.xml
 create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-ns-mountopts.xml
 create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-protocol-ver.xml
 create mode 100644 tests/storagepoolxml2xmlout/pool-rbd-ns-configopts.xml

-- 
2.20.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]