[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: process: Use enum belonging to correct type



On Fri, Jan 18, 2019 at 08:44:02AM +0100, Peter Krempa wrote:
> GCC was unhappy about comparison between two distinct enum types. Use
> the correct value instead.

It is nice to see that GCC is actually intelligent enough to catch
this kind of mistake these days !

> 
> Signed-off-by: Peter Krempa <pkrempa redhat com>
> ---
> 
> Pushed as a build fix.
> 
>  src/qemu/qemu_process.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index afa960a683..855bd9cb14 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -7835,7 +7835,7 @@ qemuProcessRefreshLegacyBlockjob(void *payload,
>          return 0;
>      }
> 
> -    if (jobtype == VIR_DOMAIN_BLOCK_JOB_TYPE_COMMIT &&
> +    if (jobtype == QEMU_BLOCKJOB_TYPE_COMMIT &&
>          disk->mirrorJob == VIR_DOMAIN_BLOCK_JOB_TYPE_ACTIVE_COMMIT)
>          jobtype = disk->mirrorJob;
> 
> -- 
> 2.20.1
> 
> --
> libvir-list mailing list
> libvir-list redhat com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]