[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 06/18] conf: Add <hostdev model='virtio-{non-}transitional'/>

On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
>  typedef struct _virDomainHostdevSubsysSCSIVHost virDomainHostdevSubsysSCSIVHost;
>  typedef virDomainHostdevSubsysSCSIVHost *virDomainHostdevSubsysSCSIVHostPtr;
>  struct _virDomainHostdevSubsysSCSIVHost {
>      int protocol; /* enum virDomainHostdevSubsysSCSIHostProtocolType */
>      char *wwpn;
> +    int model; /* enum virDomainHostdevSubsysSCSIVHostModelType */
>  };

There is no check for the value of model in
virDomainHostdevDefCheckABIStability(). Interestingly, the same
is true for mdevs, so that looks like an oversight that can be
corrected there as well.

Everything else looks reasonable, including the decision to use
model=virtio-* instead of model=vhost-* considering that neither
approach would be completely satisfactory anyway, so

  Reviewed-by: Andrea Bolognani <abologna redhat com>

Andrea Bolognani / Red Hat / Virtualization

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]