[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 09/18] conf: Add <filesystem model='virtio-{non-}transitional'/>



On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
[...]
> +VIR_ENUM_IMPL(virDomainFSModel, VIR_DOMAIN_FS_MODEL_LAST,
> +              "default",
> +              "virtio",
> +              "virtio-transitional",
> +              "virtio-non-transitional")

Here as well, you can have

  VIR_ENUM_IMPL(virDomainFSModel,
      ...
      "virtio-non-transitional",
  );

to prepare for further changes.

Everything else looks good, so

  Reviewed-by: Andrea Bolognani <abologna redhat com>

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]