[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2] qemu: command: Don't format image properties for empty -drive



On Wed, Jan 16, 2019 at 10:42:10AM +0100, Peter Krempa wrote:
> If a -drive has no image, using image properties makes qemu whine that
> they should not be used.
> 
> This patch stops formating cache/readonly/... for empty drives
> for the pre-blockdev syntax. Unfortunately those parameters can't be
> added later when inserting media, but on the other hand qemu will start
> with an empty drive.
> 
> Since we already were able to start a VM with such config previously due
> to qemu ignoring them I've opted just to skip formatting them.
> Additionally with -blockdev support it will work as expected as the
> image properties will be formatted when adding the image itself which is
> not possible without it.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1651457
> 
> Signed-off-by: Peter Krempa <pkrempa redhat com>
> ---
>  src/qemu/qemu_command.c                       | 47 ++++++++++---------
>  tests/qemuxml2argvdata/disk-cdrom.args        |  4 +-
>  .../disk-cdrom.x86_64-2.12.0.args             |  4 +-
>  .../disk-cdrom.x86_64-latest.args             |  4 +-
>  4 files changed, 30 insertions(+), 29 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange redhat com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]