[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/18] conf: Add <disk model='virtio-{non-}transitional'/>



On 01/18/2019 06:24 AM, Andrea Bolognani wrote:
> On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
> 
> [...]
> 

> 
> So you got rid of the macro from RFC's 2/6 completely? Despite the
> code duplication issue I've pointed out at the time, I'd still
> rather see that macro being used, after renaming it, than yet
> another hardcoded list of capabilities...
> 
> 

It turned out to not need too many caps adjustments throughout the
series so I dropped it incase it was a distraction. It's on my list to
send a separate series for DO_TEST_CAPS+qemuxml2xml, hopefully sharing
more with the qemuxml2argv implementation

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]