[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 13/18] qemu: Support vsock model=virtio-{non-}transitional



On Tue, 2019-01-22 at 12:31 -0500, Cole Robinson wrote:
> On 01/21/2019 10:48 AM, Andrea Bolognani wrote:
> > On Thu, 2019-01-17 at 12:52 -0500, Cole Robinson wrote:
> > [...]
> > > +++ b/tests/qemuxml2xmltest.c
> > > @@ -1269,12 +1269,14 @@ mymain(void)
> > >              QEMU_CAPS_DEVICE_VIDEO_PRIMARY,
> > >              QEMU_CAPS_DEVICE_PCIE_PCI_BRIDGE,
> > >              QEMU_CAPS_DEVICE_PCIE_ROOT_PORT,
> > > -            QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY);
> > > +            QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY,
> > > +            QEMU_CAPS_DEVICE_VHOST_VSOCK);
> > >      DO_TEST("virtio-non-transitional",
> > >              QEMU_CAPS_DEVICE_VIDEO_PRIMARY,
> > >              QEMU_CAPS_DEVICE_PCIE_PCI_BRIDGE,
> > >              QEMU_CAPS_DEVICE_PCIE_ROOT_PORT,
> > > -            QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY);
> > > +            QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY,
> > > +            QEMU_CAPS_DEVICE_VHOST_VSOCK);
> > 
> > This could have gone into patch 2/18.
> 
> Seems a little strange since it only became relevant with this patch,
> but I'll change it

Fair enough. Feel free to leave this, and others, as is.

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]