[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 16/18] qemu: Support scsi controller model=virtio-{non-}transitional



On Wed, 2019-01-23 at 07:52 -0500, Cole Robinson wrote:
> On 01/23/2019 07:08 AM, Andrea Bolognani wrote:
> > Better yet, you don't even need to add that switch statement to
> > qemuBuildVirtioDevStr(): you can just use virDomainDeviceGetInfo()
> > instead, thus making the code shorter and nicer :)
> 
> Ah good catch, though the switch statement will end up in the final
> result anyways with all the transitional additions

That's a very solid point :) Sorry for the noise.

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]