[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: improve compile-time check of qemuBlockjobState mapping



On Wed, Jan 23, 2019 at 13:45:07 -0600, Eric Blake wrote:
> Asserting the value we set four lines earlier in qemuBlockjobState
> doesn't buy us any safety (if the public header adds a value, we end
> up skipping that value without the compiler warning us of our gap);
> what we really want is to assert that the value auto-assigned by the
> compiler matches the actual last value in the public headers (as was
> done below for qemuBlockJobType).  Add useful comments while at it.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---

ACK

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]