[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] conf: add debugcon-isa chardev guest interface




On 25.01.2019 16:37, Ján Tomko wrote:
> On Thu, Jan 24, 2019 at 05:28:59PM +0300, Nikolay Shirokovskiy wrote:
>> This interface can be used for example by firmware to print
>> debug messages. Here is domain xml example:
>>
>>    <channel type='file'>
>>      <source path='/var/log/libvirt/qemu/VM.firmware.log'/>
>>      <target type='debugcon-isa'/>
> 
> IMO 'debugcon' would be enough.

I followed serial chardev xml. It uses pci-serial, usb-serial etc
for target type. I think idea is to make it possible to specify
type when address is not specified (if it is then one can use 
address type to distinguish). Of course we have only isa-debugcon
device yet. However I agree that for channel configuration having
enumeration like spicevm, guesfw, debugcon-isa looks like mixing
types and subtypes.

Nikolay

> 
> Jano
> 
>>      <address type='isa' iobase='0x402'/>
>>    </channel>
>>
>> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy virtuozzo com>
>> ---
>> docs/formatdomain.html.in                         | 11 ++++++
>> docs/schemas/domaincommon.rng                     |  8 +++++
>> src/conf/domain_conf.c                            |  6 +++-
>> src/conf/domain_conf.h                            |  1 +
>> src/qemu/qemu_command.c                           |  3 ++
>> tests/qemuxml2argvdata/channel-debugcon-isa.xml   | 34 +++++++++++++++++++
>> tests/qemuxml2xmloutdata/channel-debugcon-isa.xml | 41 +++++++++++++++++++++++
>> tests/qemuxml2xmltest.c                           |  1 +
>> 8 files changed, 104 insertions(+), 1 deletion(-)
>> create mode 100644 tests/qemuxml2argvdata/channel-debugcon-isa.xml
>> create mode 100644 tests/qemuxml2xmloutdata/channel-debugcon-isa.xml
>>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]