[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/11] qemu: domain: Allow overriding disk source in qemuDomainDetermineDiskChain




On 1/23/19 11:10 AM, Peter Krempa wrote:
> When we need to detect a chain for a image which will become the new
> source for a disk (e.g. after a disk media change or a blockjob) we'd
> need to replace disk->src temporarily to do so.
> 
> Move the 'disksrc' temporary variable as an argument and adjust callers.
> 

s/as an/to an API/

> Signed-off-by: Peter Krempa <pkrempa redhat com>
> ---
>  src/qemu/qemu_blockjob.c |  2 +-
>  src/qemu/qemu_domain.c   | 15 ++++++++++++++-
>  src/qemu/qemu_domain.h   |  1 +
>  src/qemu/qemu_driver.c   |  2 +-
>  src/qemu/qemu_hotplug.c  |  4 ++--
>  src/qemu/qemu_process.c  |  4 ++--
>  6 files changed, 21 insertions(+), 7 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]