[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/9] Add semicolon to VIR_ENUM_IMPL calls




On 1/23/19 5:46 PM, Cole Robinson wrote:
> Missing semicolon at the end of macros can confuse some analyzers
> (like cppcheck <filename>), and we have a mix of semicolon and
> non-semicolon usage through the code. Let's standardize on using
> a semicolon for VIR_ENUM_IMPL calls.
> 
> Signed-off-by: Cole Robinson <crobinso redhat com>
> ---
>  src/conf/cpu_conf.c              |  14 +--
>  src/conf/domain_conf.c           | 168 +++++++++++++++----------------
>  src/conf/interface_conf.c        |   2 +-
>  src/conf/netdev_vlan_conf.c      |   2 +-
>  src/conf/network_conf.c          |   8 +-
>  src/conf/node_device_conf.c      |   8 +-
>  src/conf/numa_conf.c             |   2 +-
>  src/conf/snapshot_conf.c         |   4 +-
>  src/conf/storage_adapter_conf.c  |   2 +-
>  src/conf/storage_conf.c          |  16 +--
>  src/lxc/lxc_domain.c             |   4 +-
>  src/qemu/qemu_command.c          |   2 +-
>  src/qemu/qemu_driver.c           |   4 +-
>  src/qemu/qemu_monitor.c          |   8 +-
>  src/qemu/qemu_monitor_json.c     |   2 +-
>  src/remote/remote_daemon.c       |   2 +-
>  src/util/virerror.c              |   2 +-
>  src/util/virfirewall.c           |   2 +-
>  src/util/virhook.c               |  14 +--
>  src/util/virmdev.c               |   2 +-
>  src/util/virnetdev.c             |   4 +-
>  src/util/virnetdevmacvlan.c      |   2 +-
>  src/util/virnetdevvportprofile.c |   4 +-
>  src/util/virpci.c                |   2 +-
>  src/util/virresctrl.c            |   8 +-
>  src/util/virsecret.c             |   2 +-
>  src/util/virstorageencryption.c  |   4 +-
>  src/util/virstoragefile.c        |  14 +--
>  src/util/virtypedparam.c         |   2 +-
>  src/util/virutil.c               |   4 +-
>  src/util/virutil.h               |   2 +-
>  tools/virsh-domain-monitor.c     |  24 ++---
>  tools/virsh-domain.c             |  54 +++++-----
>  tools/virsh-network.c            |   4 +-
>  tools/virsh-nodedev.c            |   2 +-
>  tools/virsh-pool.c               |   4 +-
>  tools/virsh-secret.c             |   2 +-
>  tools/virsh-volume.c             |   2 +-
>  tools/virt-admin.c               |   2 +-
>  39 files changed, 205 insertions(+), 205 deletions(-)
> 

[...]

> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 41d345a23e..f580114d55 100644
[...]

>  VIR_ENUM_IMPL(virDomainMemballoonModel, VIR_DOMAIN_MEMBALLOON_MODEL_LAST,
>                "virtio",

Missed this one

[...]

>  
>  VIR_ENUM_IMPL(virDomainVsockModel, VIR_DOMAIN_VSOCK_MODEL_LAST,
>                "default",
> @@ -881,41 +881,41 @@ VIR_ENUM_IMPL(virDomainVsockModel, VIR_DOMAIN_VSOCK_MODEL_LAST,

Missed this one.

Same for patch 9

Other than that.... If someone is slick enough to generate a
syntax-check rule for patch 9, then great; otherwise, it's code review
diligence or a friendly word in hacking.html.in.


Reviewed-by: John Ferlan <jferlan redhat com>
(series)

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]