[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 09/10] storage: Add NFS storage pool namespace options to command line



On Thu, Jan 17, 2019 at 04:22:15PM -0500, John Ferlan wrote:
> If the NetFS Storage Pool Namespace XML data exists, format the
> mount options on the MOUNT command line.
> 
> When the pool is started, the options will be generated on the
> command line along with the options already defined.
> 
> To view the options of the running pool, use either 'nfsstat -m'
> or 'grep $POOLNAME /proc/mounts' for the added Flags/options.
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/storage/storage_util.c                             | 10 +++++++++-
>  .../pool-netfs-ns-mountopts-freebsd.argv               |  2 ++
>  .../pool-netfs-ns-mountopts-linux.argv                 |  2 ++
>  .../pool-netfs-ns-mountopts.argv                       |  1 +
>  tests/storagepoolxml2argvtest.c                        |  6 ++++++
>  5 files changed, 20 insertions(+), 1 deletion(-)
>  create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-ns-mountopts-freebsd.argv
>  create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-ns-mountopts-linux.argv
>  create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-ns-mountopts.argv

Reviewed-by: Daniel P. Berrangé <berrange redhat com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]