[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] docs: Format bit shift notation for bitwise flag enums




On 1/24/19 9:43 AM, Peter Krempa wrote:
> Big number itself does not make much sense in some cases. Format the
> bitshift format as well.
> 
> Changes our web page docs from:
> 
> VIR_MIGRATE_POSTCOPY = 32768 : Setting the VIR_MIGRATE_POSTCOPY...
> VIR_MIGRATE_TLS      = 65536 : Setting the VIR_MIGRATE_TLS flag...
> 
> to:
> 
> VIR_MIGRATE_POSTCOPY = 32768 (1<<15) : Setting the VIR_MIGRATE_POSTCOPY...
> VIR_MIGRATE_TLS      = 65536 (1<<16) : Setting the VIR_MIGRATE_TLS flag...

Do you (or does anyone) think perhaps it should be (1 << 15)?

NB: There is one comment for VIR_DOMAIN_AFFECT_CONFIG which has 1 << 2
and that looks cleaner w/ the spacing.

> 
> Signed-off-by: Peter Krempa <pkrempa redhat com>
> ---
>  docs/apibuild.py |  4 ++++
>  docs/libvirt.css |  4 ++++
>  docs/newapi.xsl  | 15 +++++++++++++--
>  3 files changed, 21 insertions(+), 2 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]