[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 16/25] qemu: Support rng model=virtio-{non-}transitional



On Wed, 2019-01-23 at 16:32 -0500, Cole Robinson wrote:
[...]
> @@ -4550,6 +4550,14 @@ qemuDomainRNGDefValidate(const virDomainRNGDef *def,
>          model_supported = virQEMUCapsGet(qemuCaps,
>                                           QEMU_CAPS_DEVICE_VIRTIO_RNG);
>          break;
> +    case VIR_DOMAIN_RNG_MODEL_VIRTIO_TRANSITIONAL:
> +        model_supported = (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_RNG_PCI_TRANSITIONAL) ||
> +                           virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY));
> +        break;
> +    case VIR_DOMAIN_RNG_MODEL_VIRTIO_NON_TRANSITIONAL:
> +        model_supported = (virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VIRTIO_RNG_PCI_NON_TRANSITIONAL) ||
> +                           virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY));
> +        break;

Of course you now need s/model_supported/modelIsSupported/g now.

Aside from that and the usual stuff everything looks good, so

  Reviewed-by: Andrea Bolognani <abologna redhat com>

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]