[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 20/25] qemu: Support vsock model=virtio-{non-}transitional



On Wed, Jan 23, 2019 at 04:32:48PM -0500, Cole Robinson wrote:
Add <vsock> model handling for virtio transitional devices. Ex:

 <vsock model='virtio-transitional'>
   ...
 </vsock>

* "virtio-transitional" maps to qemu "vhost-vsock-pci-transitional"
* "virtio-non-transitional" maps to qemu "vhost-vsock-pci-non-transitional"

Signed-off-by: Cole Robinson <crobinso redhat com>
---
docs/formatdomain.html.in                           |  4 +++-
docs/schemas/domaincommon.rng                       |  6 +++++-
src/conf/domain_conf.c                              |  5 ++++-
src/conf/domain_conf.h                              |  2 ++
src/qemu/qemu_command.c                             |  9 +++++++--
src/qemu/qemu_domain_address.c                      | 13 ++++++++++++-
.../virtio-non-transitional.x86_64-3.1.0.args       |  3 +++
.../virtio-non-transitional.x86_64-latest.args      |  3 +++
tests/qemuxml2argvdata/virtio-non-transitional.xml  |  3 +++
.../virtio-transitional.x86_64-3.1.0.args           |  1 +
.../virtio-transitional.x86_64-latest.args          |  2 ++
tests/qemuxml2argvdata/virtio-transitional.xml      |  3 +++
.../qemuxml2xmloutdata/virtio-non-transitional.xml  |  9 +++++++++
tests/qemuxml2xmloutdata/virtio-transitional.xml    |  4 ++++
tests/qemuxml2xmltest.c                             |  6 ++++--
15 files changed, 65 insertions(+), 8 deletions(-)

@@ -10494,7 +10500,6 @@ qemuBuildVsockDevStr(virDomainDefPtr def,
    virBuffer buf = VIR_BUFFER_INITIALIZER;
    char *ret = NULL;

-
    if (qemuBuildVirtioDevStr(&buf, "vhost-vsock", qemuCaps,
                              VIR_DOMAIN_DEVICE_VSOCK, vsock) < 0) {
        goto cleanup;

Unrelated whitespace change.

Jano

Attachment: signature.asc
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]