[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 25/25] qemu: domcaps: Report disk <enum name="model">



On Wed, 2019-01-23 at 16:32 -0500, Cole Robinson wrote:
[...]
> +++ b/tests/domaincapsschemadata/qemu_4.0.0.x86_64.xml
> @@ -0,0 +1,154 @@
> +<domainCapabilities>
> +  <path>/usr/bin/qemu-system-x86_64</path>
> +  <domain>kvm</domain>
> +  <machine>pc-i440fx-4.0</machine>
     ...
> +</domainCapabilities>

This hunk...

[...]
> +++ b/tests/domaincapstest.c
> @@ -502,6 +503,9 @@ mymain(void)
>                   "/usr/bin/qemu-system-s390x", NULL,
>                   "s390x", VIR_DOMAIN_VIRT_KVM);
>  
> +    DO_TEST_QEMU("4.0.0", "caps_4.0.0",
> +                 "/usr/bin/qemu-system-x86_64", NULL,
> +                 "x86_64", VIR_DOMAIN_VIRT_KVM);

... and this one should be split into their own preparatory patch,
so that all the test suite changes we see in this one are a direct
consequence of adding the new information.

After the split,

  Reviewed-by: Andrea Bolognani <abologna redhat com>

to both resulting patches :)

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]