[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH v5 0/9] Allow adding mountOpts to the storage pool mount command



v4: https://www.redhat.com/archives/libvir-list/2019-January/msg00614.html

NB: Still keeping same subject for cover to keep the same context even
    though the contents are very different from the original.

Changes since v4:

 * Alter patch1 to make the addition of mount options more generic to
   "fs" and "netfs" pools. Tested/generated the output for all the various
   pools by modifying the sources, using VIR_TEST_REGENERATE_OUTPUT and
   having specific "linux" or "freebsd" output.

 * Alter patch2 to rephrase the news article and add the R-by

 * Alter patch3 to add the R-by

 * Alter patch4 to account for changes in patch1 and to only add the
   nfsvers=%u to/for NETFS type pools passing that argument along to
   the called methods. Left off the R-by since I changed things.

 * Alter patch5 and patch6 to add the R-by

 * Combine patch7 and patch8 into one larger patch accounting for review
   comments mostly from the former patch8. Modify the docs to indicate lack
   of support guarantees, changed the "netfs:" to be just "fs:", fixed the
   comments in storage_pool_fs, and changed methods/structs to use FS and
   not NetFS. Left off the R-by since I changed things.

 * Modify patch9 to use the new struct names and add a taint VIR_WARN message.
   Theoretically this could be combined with the previous too if we really
   desired to make one large patch. Left off the R-by since I changed things.

 * Modify patch10 to add the taint message and fix the poorly cut-n-paste'd
   code that neglected to rename the new struct to use "Config" instead of
   "Mount". Left off the R-by since I changed things.

John Ferlan (9):
  storage: Add default mount options for fs/netfs storage pools
  docs: Add news mention of default fs/netfs storage pool mount options
  conf: Add optional NFS Source Pool <protocol ver='n'/> option
  storage: Add the nfsvers to the command line
  virsh: Add source-protocol-ver for pool commands
  conf: Introduce virStoragePoolXMLNamespace
  storage: Add infrastructure to manage XML namespace options
  storage: Add storage pool namespace options to fs and netfs command
    lines
  rbd: Utilize storage pool namespace to manage config options

 docs/formatstorage.html.in                    | 129 +++++++++++++
 docs/news.xml                                 |  11 ++
 docs/schemas/storagepool.rng                  |  53 ++++++
 src/conf/storage_conf.c                       |  73 +++++++-
 src/conf/storage_conf.h                       |  27 +++
 src/libvirt_private.syms                      |   1 +
 src/storage/storage_backend_fs.c              | 132 ++++++++++++++
 src/storage/storage_backend_rbd.c             | 169 +++++++++++++++++-
 src/storage/storage_util.c                    |  81 ++++++++-
 src/storage/storage_util.h                    |  14 ++
 tests/Makefile.am                             |   4 +-
 .../pool-fs-freebsd.argv                      |   1 +
 .../pool-fs-linux.argv                        |   1 +
 .../pool-netfs-auto-freebsd.argv              |   1 +
 .../pool-netfs-auto-linux.argv                |   1 +
 .../pool-netfs-cifs-freebsd.argv              |   1 +
 .../pool-netfs-cifs-linux.argv                |   1 +
 .../pool-netfs-freebsd.argv                   |   1 +
 .../pool-netfs-gluster-freebsd.argv           |   2 +
 .../pool-netfs-gluster-linux.argv             |   2 +
 .../pool-netfs-linux.argv                     |   1 +
 .../pool-netfs-ns-mountopts-freebsd.argv      |   2 +
 .../pool-netfs-ns-mountopts-linux.argv        |   2 +
 .../pool-netfs-ns-mountopts.argv              |   1 +
 .../pool-netfs-protocol-ver-freebsd.argv      |   1 +
 .../pool-netfs-protocol-ver-linux.argv        |   2 +
 .../pool-netfs-protocol-ver.argv              |   1 +
 tests/storagepoolxml2argvtest.c               |  57 +++++-
 .../pool-netfs-ns-mountopts.xml               |  25 +++
 .../pool-netfs-protocol-ver.xml               |  21 +++
 .../pool-rbd-ns-configopts.xml                |  17 ++
 .../pool-netfs-ns-mountopts.xml               |  25 +++
 .../pool-netfs-protocol-ver.xml               |  21 +++
 .../pool-rbd-ns-configopts.xml                |  20 +++
 tests/storagepoolxml2xmltest.c                |   8 +
 tools/virsh-pool.c                            |  12 +-
 tools/virsh.pod                               |   5 +
 37 files changed, 903 insertions(+), 23 deletions(-)
 create mode 100644 tests/storagepoolxml2argvdata/pool-fs-freebsd.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-fs-linux.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-auto-freebsd.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-auto-linux.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-cifs-freebsd.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-cifs-linux.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-freebsd.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-gluster-freebsd.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-gluster-linux.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-linux.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-ns-mountopts-freebsd.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-ns-mountopts-linux.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-ns-mountopts.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-protocol-ver-freebsd.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-protocol-ver-linux.argv
 create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-protocol-ver.argv
 create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-ns-mountopts.xml
 create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-protocol-ver.xml
 create mode 100644 tests/storagepoolxml2xmlin/pool-rbd-ns-configopts.xml
 create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-ns-mountopts.xml
 create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-protocol-ver.xml
 create mode 100644 tests/storagepoolxml2xmlout/pool-rbd-ns-configopts.xml

-- 
2.20.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]