[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v5 7/9] storage: Add infrastructure to manage XML namespace options



On Tue, Jan 29, 2019 at 01:22:06PM -0500, John Ferlan wrote:
> Introduce the virStoragePoolFSMountOptionsDef to be used to
> manage the Storage Pool XML Namespace for mount options.
> 
> Using a new virStorageBackendNamespaceInit function, set the
> virStoragePoolXMLNamespace into the _virStoragePoolOptions when
> the storage backend is loaded.
> 
> Modify the storagepool.rng to allow for the usage of a different
> XML namespace to parse the fs_mount_opts to be included with
> the fs and netfs storage pool definitions.
> 
> Modify the storagepoolxml2xmltest to utilize a properly modified
> XML file to parse and format the namespace for a netfs storage pool.
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  docs/formatstorage.html.in                    |  63 +++++++++
>  docs/schemas/storagepool.rng                  |  23 +++
>  src/storage/storage_backend_fs.c              | 132 ++++++++++++++++++
>  src/storage/storage_util.c                    |  16 +++
>  src/storage/storage_util.h                    |  14 ++
>  tests/Makefile.am                             |   4 +-
>  .../pool-netfs-ns-mountopts.xml               |  25 ++++
>  .../pool-netfs-ns-mountopts.xml               |  25 ++++
>  tests/storagepoolxml2xmltest.c                |   6 +
>  9 files changed, 307 insertions(+), 1 deletion(-)
>  create mode 100644 tests/storagepoolxml2xmlin/pool-netfs-ns-mountopts.xml
>  create mode 100644 tests/storagepoolxml2xmlout/pool-netfs-ns-mountopts.xml

Reviewed-by: Daniel P. Berrangé <berrange redhat com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]