[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v5 8/9] storage: Add storage pool namespace options to fs and netfs command lines



On Tue, Jan 29, 2019 at 01:22:07PM -0500, John Ferlan wrote:
> If the Storage Pool Namespace XML data exists, format the mount
> options on the MOUNT command line and issue a VIR_WARN to indicate
> that the storage pool was tainted by custom mount_opts.
> 
> When the pool is started, the options will be generated on the
> command line along with the options already defined.
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  src/storage/storage_util.c                    | 22 +++++++++++++++----
>  .../pool-netfs-ns-mountopts-freebsd.argv      |  2 ++
>  .../pool-netfs-ns-mountopts-linux.argv        |  2 ++
>  .../pool-netfs-ns-mountopts.argv              |  1 +
>  tests/storagepoolxml2argvtest.c               |  6 +++++
>  5 files changed, 29 insertions(+), 4 deletions(-)
>  create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-ns-mountopts-freebsd.argv
>  create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-ns-mountopts-linux.argv
>  create mode 100644 tests/storagepoolxml2argvdata/pool-netfs-ns-mountopts.argv

Reviewed-by: Daniel P. Berrangé <berrange redhat com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]