[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v5 9/9] rbd: Utilize storage pool namespace to manage config options



On Tue, Jan 29, 2019 at 01:22:08PM -0500, John Ferlan wrote:
> Allow for adjustment of RBD configuration options via Storage
> Pool XML Namespace adjustments. When namespace arguments are
> used to start the pool, add a VIR_WARN to indicate that the
> startup was tainted by custom config_opts.
> 
> Based off original patch/concept:
> 
> https://www.redhat.com/archives/libvir-list/2014-May/msg00940.html
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  docs/formatstorage.html.in                    |  52 +++++-
>  docs/schemas/storagepool.rng                  |  23 +++
>  src/storage/storage_backend_rbd.c             | 169 +++++++++++++++++-
>  .../pool-rbd-ns-configopts.xml                |  17 ++
>  .../pool-rbd-ns-configopts.xml                |  20 +++
>  tests/storagepoolxml2xmltest.c                |   1 +
>  6 files changed, 278 insertions(+), 4 deletions(-)
>  create mode 100644 tests/storagepoolxml2xmlin/pool-rbd-ns-configopts.xml
>  create mode 100644 tests/storagepoolxml2xmlout/pool-rbd-ns-configopts.xml

Reviewed-by: Daniel P. Berrangé <berrange redhat com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]