[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/6] A few misc fixes from LGTM static analysis

There is an online service call LGTM (Looks Good To Me) which does
static analysis of open source projects and I happened to learn that
they include coverage of libvirt


I looked at the alerts they reported. Currently no errors, 41 warnings
and 90 recommendations (79 of which are FIXME comments :-).

There's nothing particularly important they identify right now, but I
felt like addressing a few of them anyway, hence this series.

Daniel P. Berrangé (6):
  conf: remove pointless check on enum value
  remote: remove variable whose value is a constant
  storage: pass struct _virStorageBackendQemuImgInfo by reference
  qemu: pass virDomainDeviceInfo by reference
  hyperv: remove unused 'total' variable
  hyperv: use "is None" not "== None" for PEP-8 compliance

 src/conf/domain_conf.c              | 20 ++++++++---------
 src/hyperv/hyperv_wmi_generator.py  |  3 +--
 src/qemu/qemu_command.c             |  4 ++--
 src/qemu/qemu_domain.c              | 10 ++++-----
 src/qemu/qemu_domain.h              |  9 ++++----
 src/qemu/qemu_domain_address.c      |  2 +-
 src/remote/remote_daemon_dispatch.c |  8 ++-----
 src/storage/storage_util.c          | 35 ++++++++++++++---------------
 8 files changed, 42 insertions(+), 49 deletions(-)


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]