[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/6] qemu: pass virDomainDeviceInfo by reference




On 1/30/19 12:40 PM, Daniel P. Berrangé wrote:
> The virDomainDeviceInfo parameter is a large struct so it is preferrable
> to pass it by reference instead of by value.
> 
> Signed-off-by: Daniel P. Berrangé <berrange redhat com>
> ---
>  src/qemu/qemu_command.c        |  4 ++--
>  src/qemu/qemu_domain.c         | 10 +++++-----
>  src/qemu/qemu_domain.h         |  9 +++++----
>  src/qemu/qemu_domain_address.c |  2 +-
>  4 files changed, 13 insertions(+), 12 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]