[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 6/6] hyperv: use "is None" not "== None" for PEP-8 compliance




On 1/30/19 12:40 PM, Daniel P. Berrangé wrote:
> PEP 8 says:
> 
>     "Comparisons to singletons like None should always be done
>      with 'is' or 'is not', never the equality operators."
> 
> There are potentially semantics differences, though in the case of this
> libvirt code its merely a style change:
> 
>   http://jaredgrubb.blogspot.com/2009/04/python-is-none-vs-none.html
> 
> Signed-off-by: Daniel P. Berrangé <berrange redhat com>
> ---
>  src/hyperv/hyperv_wmi_generator.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: John Ferlan <jferlan redhat com>

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]