[libvirt] [PATCH 2/3] bhyve: emit warning when using bhyve:commandline

Roman Bogorodskiy bogorodskiy at gmail.com
Thu Jan 31 12:41:25 UTC 2019


When using custom command line arguments, warn that
this configuration is not fully supported.

Signed-off-by: Roman Bogorodskiy <bogorodskiy at gmail.com>
---
 src/bhyve/bhyve_command.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c
index a1ae2026a0..1f215dac08 100644
--- a/src/bhyve/bhyve_command.c
+++ b/src/bhyve/bhyve_command.c
@@ -630,6 +630,10 @@ virBhyveProcessBuildBhyveCmd(virConnectPtr conn,
     if (def->namespaceData) {
         bhyveDomainCmdlineDefPtr bhyvecmd;
 
+        VIR_WARN("Booting the guest using command line pass-through feature, "
+                 "which could potentially cause inconsistent state and "
+                 "upgrade issues");
+
         bhyvecmd = def->namespaceData;
         for (i = 0; i < bhyvecmd->num_args; i++)
             virCommandAddArg(cmd, bhyvecmd->args[i]);
-- 
2.20.1




More information about the libvir-list mailing list