[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [cim PATCH] configure: no need to tell us we can run make



On Thu, Jan 31, 2019 at 02:13:33PM +0100, Martin Kletzander wrote:
> On Thu, Jan 31, 2019 at 12:53:31PM +0000, Daniel P. Berrangé wrote:
> > autogen.sh already tells us we can run make, there's no need for
> > configure.ac to tell us too.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange redhat com>
> > ---
> > configure.ac | 2 --
> > 1 file changed, 2 deletions(-)
> > 
> > diff --git a/configure.ac b/configure.ac
> > index 2439dbe..28bfc16 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -195,5 +195,3 @@ echo "----------------------------------------------------------"
> > 
> > # Generate configure scripts for the Makefile
> > AC_OUTPUT(libvirt-cim.spec)
> > -
> > -echo "You may now run make"
> > -- 
> > 2.20.1
> > 
> 
> Wouldn't it make sense to remove it from autogen then?  That would tell this to
> people building from dist tarball as well.

True, or we could just remove it from both places. if you don't know
that you need to run 'make' you probably wouldn't have figured out
that you needed to run 'configure' in the first place :-)


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]