[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 09/27] conf: introduce virNetworkPortDefPtr struct and XML support



On Thu, Jan 31, 2019 at 01:48:33PM +0000, Daniel P. Berrangé wrote:
> On Tue, Jan 08, 2019 at 05:15:49PM +0100, Michal Privoznik wrote:
> > On 12/24/18 3:58 PM, Daniel P. Berrangé wrote:
> > > Introduce a virNetworkPortDefPtr struct to represent the data associated
> > > with a virtual network port. Add APIs for parsing/formatting XML docs
> > > with the data.
> > > 
> > > Signed-off-by: Daniel P. Berrangé <berrange redhat com>
> 
> [snip]

> > > +    if (def->trustGuestRxFilters)
> > > +        virBufferAsprintf(buf, "<rxfilters trustGuest='%s'/>",
> > 
> > Add "\n" here.
> 
> Yep, this shows some missing coverage in the test XML files which
> I'll address too.

And adding them made me discover this patch missed parsing of
the <class id=/> element.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]