[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/3] storagepoolxml2argvtest: delete some lines



On Thu, 2019-01-31 at 15:54 +0100, Ján Tomko wrote:
> Also fix the build on FreeBSD
> 
> Ján Tomko (3):
>   storagepoolxml2argvtest: pass the platform suffix as a string
>   storagepoolxml2argvtest: introduce DO_TEST_PLATFORM
>   storagepoolxml2argvtest: run mountopts test conditionally
> 
>  tests/storagepoolxml2argvtest.c | 76 +++++++++++++++--------------------------
>  1 file changed, 28 insertions(+), 48 deletions(-)

I love it.

Assuming you have compile-tested the series on the relevant
platforms, which I can't really be bothered doing right now, you
can sprinkle it with some

  Reviewed-by: Andrea Bolognani <abologna redhat com>

and push away.

-- 
Andrea Bolognani / Red Hat / Virtualization


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]